fix #77 and other race condition bugs #78
Conversation
There was a problem hiding this comment.
Thank you for your contribution. I haven't had the time to look over your other contributions. But a few comments regarding this one:
The purpose of LiveData is to update the data in the view without strong coupling and callbacks like this. Reinitiating the viewmodel manually every time the data changes seems like a very difficult solution to me.
It would be much easier to just change the MutableLiveData to MediatorLiveData and introduce a new getter in the DAO that returns LiveData. This way the LiveData will automatically be triggered when the database changes and thus the view will automatically update on database changes.
|
Thanks for the feedback. |
Privacy - to indicate I read CONTRIBUTING.md.
This fixes the bugs described in #77. It furthermore fixes a similar bug: When adding a food it may not show in the overview list and the sum of total calories, until the overview activity is reloaded.
All these bugs happen, because the changes to the database are done via executor on another thread, so that the UI updates before the changes are written to the database.